Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache disabled after run "composer update" command #24892

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 commented Oct 6, 2019

Implement file lock system when cleaning generated files, avoid race condition upon cleaning generated code.

Description (*)

Cache gets sometimes disabled after a composer operation modifying packages due to concurrency / race conditions problems. Full description here: #17634 (comment)

Duplicate of PR #24560, but as it does not seem to be maintained anymore to implement this changes, this new PR is open as specified in #24560 (comment)

Fixed Issues (if relevant)

1.#17634: Cache disabled after run "composer update" command
2. mailchimp/mc-magento2#457: Setup upgrade works more than 15 minutes during installing module

Manual testing scenarios (*)

  1. Full info at Cache disabled after run "composer update" command #17634 (comment)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 6, 2019

Hi @adrian-martinez-interactiv4. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels Oct 6, 2019
@dmytro-ch dmytro-ch self-requested a review October 7, 2019 12:46
@dmytro-ch dmytro-ch self-assigned this Oct 7, 2019
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 force-pushed the FR23#CACHE-DISABLED-AFTER-COMPOSER-UPDATE branch 2 times, most recently from dfd80a7 to f547f28 Compare October 8, 2019 00:22
@ihor-sviziev ihor-sviziev self-assigned this Oct 8, 2019
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 force-pushed the FR23#CACHE-DISABLED-AFTER-COMPOSER-UPDATE branch from f547f28 to af9ca67 Compare October 8, 2019 08:53
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: complex Award: test coverage labels Oct 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6040 has been created to process this Pull Request

@osrecio osrecio self-assigned this Oct 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-6040 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before
before2

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @adrian-martinez-interactiv4, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants