Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configure): rename cmdline option --with-systemd #142

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

madrisan
Copy link
Owner

Rename --with-systemd to --enable-systemd for consistency
with the other optional boolean options.

madrisan referenced this pull request Jan 30, 2024
It seems that the glibc developers don't want to fix the year 2038 problem
in the utmp.h/utmpx.h/lastlog.h interfaces but prefer to deprecate them,
so prefer the analogous functionality provided by systemd when available.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan madrisan force-pushed the systemd-cmdline-opt branch from 1f8324b to b48f8aa Compare January 30, 2024 19:55
  Rename --with-systemd to --enable-systemd for consistency
  with the other optional boolean options.

Signed-off-by: Davide Madrisan <[email protected]>
@madrisan madrisan force-pushed the systemd-cmdline-opt branch from b48f8aa to 6391428 Compare January 30, 2024 20:33
@sbraz
Copy link
Contributor

sbraz commented Jan 30, 2024

Thanks, this works fine :)
One last question: the other options are called libcurl and libvarlink, not just curl and varlink. Is this option not called libsystemd because the library itself is rarely used without the programme (that would apply to curl too I guess)?
I don't have a strong opinion on the matter, I just noticed that my ebuild looks like this:

        $(use_enable curl libcurl)
        $(use_enable systemd)
        $(use_enable varlink libvarlink)

While the curl and varlink USE flags control lib* options, it's not the case for systemd.

@madrisan
Copy link
Owner Author

madrisan commented Feb 6, 2024

@sbraz varlink is deprecated in podman, so I will remove it. Not sure what I'll do with the docker part.

@madrisan madrisan merged commit 4a3289f into main Feb 6, 2024
16 checks passed
@madrisan madrisan deleted the systemd-cmdline-opt branch February 6, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants