Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(repo): madara orchestrator merge #480
refactor(repo): madara orchestrator merge #480
Changes from 250 commits
c81d279
1ee102b
9062d21
b04bfdd
eaf571f
eea4f83
4a948da
b420e1d
1768f47
5dd26f8
119e5bb
3fe3733
5051bec
9dcd974
e8eaeda
8c4a854
0c34cbd
fb815f7
f6c4c10
5fa41a8
f6c73c8
99b6f9d
8b3874e
b2ca7e9
52ec7fe
3af2334
267fff6
602eb9a
8384cb0
41bc907
859bacf
0f3c6c3
7a311cc
c2cd2df
b8a9748
4e4b401
ef7790b
9d5cdd7
2a9d77b
6174f9d
4343a41
b625f90
cb74280
5c96c8e
bd7854c
a342034
a4e6cba
00fc6f5
33a12b5
7baf190
7f53cf5
f1f1e4c
6803b91
d3e57f9
43db46e
c155210
b905890
36e7890
9e2369d
371d08d
73355ca
cfa43b0
5cfe98e
59d50ad
7e771e7
ae8fc95
fa59cdf
7926588
5728df2
11dc132
0ad9bfb
77bf9c6
f84ba41
21ec2cb
c3f0a50
f3e20b6
145df8e
6bd19cb
764c4fa
369ccbe
bbcf7b0
05e8acb
ab66b83
7b85453
60768cc
705b119
f65e11c
86b8d9a
ba2aeb8
63e4fa1
5922af6
ccb213b
b77250d
e5727c5
1c090fb
f5d986d
5fb2de6
64b375d
1b21d4d
82024c7
e7a51d9
b58fb2b
e14ee33
85aacf6
ce5219d
2c4c047
296c7a9
4d61e3a
ac131a5
803be5f
c66c0f3
a9d0e30
58cca2c
2ab2291
4b0fce4
9d5ace8
f79c7e1
d970d22
c2e00d1
9e67649
07c38a3
302542a
a008642
15b321b
cb8d82f
3ec2873
b9f0947
8e6bfe2
8c7fb53
59df910
3d453a2
45b1a75
1e2eede
b7c683f
0d7df60
bd1b71b
032cf5a
5cd7213
65f81f5
454b33c
c5cb404
618ceba
66a3602
3fa4632
a374764
e25f683
c5cb7b4
d0c53c9
adff744
186becd
38c2849
3a48d94
82979e0
e745ae6
caeeb7f
7010600
77b7c50
58e3040
6fa932a
1be6602
f49c663
a2d1b84
aabb156
b07f421
31361e7
7ba13ca
082a2b4
3eaff66
f1893f7
f84a3ef
df81047
f466434
acc8114
7fb7368
d954399
852e968
c24dea7
815c18f
a136fb9
d604f4e
24757d7
638b1ed
d9f5773
493ed59
a9d5e34
41f8ecd
6730bad
60f7bd6
c5c5a88
77362e3
5ebfd1d
4f08cd2
9af1ead
3d6bccb
cf3075d
d2e423e
44218ca
167be9d
a8e4ff8
431bd08
bc85952
0610a2b
df88b28
1bfa189
6d0b7e4
c80cd6d
e988ec5
a11b84c
8f27585
03de075
aa3b097
15d5fea
0d151c7
2ad572b
6747495
2ed42fa
9cb742a
4a2eb53
ddbdb59
33c1d87
f814382
0f33b58
579a52f
2497a58
73a168c
14c1e56
fc4f9e1
e8d900c
7197f15
1ff6712
6b29c28
7e0f23a
8cfba64
204e55e
c6c30c3
bb23887
d6163a4
0577f5d
80baea9
e60a591
c984ffb
73c5a85
2abdcbc
dd657c1
c0e922d
7516ec3
6e2dbba
222e3ff
22d559f
fe7c138
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment explaining the purpose of using --package "mc-" and --package "mp-" here? It would help clarify the intent behind selecting these specific package patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this was done, maybe @Mohiiit can explain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably to test the Madara crates, but a comment would provide some context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it was added to test just the madara's tests, I will add comment for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mohiiit @notlesh can you guys add the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the version is repeated many times across the workflows, should we use a constant or an environment variable to make maintenance easier? This would help keep everything in sync when updating the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo this
cc/ @Mohiiit @notlesh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is endpoint Blast absolutely necessary here? If not, please remove it from the name to keep it more generic