Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu,icu-devel: Tweak usage of muniversal #27344

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Gcenx
Copy link
Contributor

@Gcenx Gcenx commented Jan 8, 2025

macOS Mojave with a copy of MacOSX10.13.sdk and forced 10.13 deployment target can compile for i386 & x86_64

This change was required when trying to build wine-devel & wine-staging

Description

Type(s)
  • enhancement
Tested on

macOS 10.14.6
Xcode 11.3.1

Verification
  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

macOS Mojave with a copy of MacOSX10.13.sdk and forced 10.13 deployment target can compile for i386 & x86_64
@kencu
Copy link
Contributor

kencu commented Jan 9, 2025

I can't think of any bad thing that would happen to a user on 10.14 without the extra SDK and settings after this change ...

@kencu kencu merged commit 81cfbdb into macports:master Jan 9, 2025
0 of 3 checks passed
@Gcenx Gcenx deleted the icu,icu-devel-tweak-muniversal-usage branch January 9, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants