Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-pywavelets: update to 1.8.0, add py313 subport #27287

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

erikbs
Copy link
Contributor

@erikbs erikbs commented Jan 4, 2025

Description

  • Update to version 1.8.0
  • Pin py39 to version 1.5.0: PyPI says 1.6.0 is supported, but the commit history on Git removed Python 3.9 support before 1.6.0 was released
  • Append -1.5.0 to the name of the patch file for that version, add a new one for 1.8.0
  • Remove old, unreferenced patch for 1.4.1
  • Add py313 subport: Python 3.13 is officially supported by 1.8.0
  • Blacklist Clang < 1000: these versions do not support -std=c17, so Meson fails because of the option c_std=c17 in meson.build. We can patch this to c_std=c11 since these standards are essentially the same, but then we would still need to blacklist Clang < 700, because the C11 header stdatomic.h did not exist until that version (even though Clang claimed to support C11 before that). Note that putting compiler.c_standard 2017 in the Portfile instead did not work. It seems that MacPorts ignores this statement for Python ports for some unknown reason (see py313-mypy: fix compilation on OS X <= 10.9 #26719).
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.9.5 13F1911 x86_64
Xcode 6.2 6C131e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

There are no binary files. Since the developers explicitly state that they support all Python versions 3.10-3.13, I assume that they work. I also tried calling import pywt in Python 3.12 and Python 3.13, just to make sure that things have been built correctly. Both versions are imported without errors. I need this for scikit-image and do not have scripts to test PyWavelets extensively.

@macportsbot
Copy link

Notifying maintainers:
@stromnov for port py-pywavelets.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Jan 4, 2025
* Update to version 1.8.0
* Pin py39 to version 1.5.0
* Add py313 subport
* Blacklist Clang < 1000
@erikbs erikbs force-pushed the feature/py-pywavelets-upgrade branch from 855c30d to dcf4607 Compare January 4, 2025 02:15
@erikbs erikbs changed the title py-pywavelets: upgrade to 1.8.0, add py313 subport py-pywavelets: update to 1.8.0, add py313 subport Jan 4, 2025
@reneeotten reneeotten merged commit 8a13779 into macports:master Jan 9, 2025
3 checks passed
@erikbs erikbs deleted the feature/py-pywavelets-upgrade branch January 9, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

4 participants