-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtatsu: Add port. #27258
libtatsu: Add port. #27258
Conversation
619ba21
to
f1419c1
Compare
Sorry, had some problems with the devel variant, fixing it. |
|
f1419c1
to
f49b2f3
Compare
Seems to be ok to merge now. |
devel/libtatsu/Portfile
Outdated
} | ||
|
||
if {${subport} eq ${name}} { | ||
conflicts libirecovery-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be "libtatsu-devel"? Also, I don't think it doesn't need to be in this block, it can just go up close to the "name" field - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, missed that one. do you mean I should move it up in the file? that part wasn't changed a lot from the libirecovery portfile, libplist portfile https://github.com/macports/macports-ports/blob/master/textproc/libplist/Portfile seems to do this in a similar way. I'm open to changes though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the name fix for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, move it up to under the "name" field. Double check that it works correctly, but it should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved it up, but now for some reason my local port lint is unhappy about libtatsu-devel port not being known. CI seems to like everything.
f49b2f3
to
518aff0
Compare
devel/libtatsu/Portfile
Outdated
} | ||
|
||
if {${subport} eq ${name}} { | ||
conflicts libirecovery-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, move it up to under the "name" field. Double check that it works correctly, but it should
b697eb0
to
d1c79e7
Compare
I've also changed it to act more like libplist's port to save some build time by not running |
d1c79e7
to
9cd951c
Compare
@turbocool3r I did take a look at this PR locally and made a few changes. I think this should be good to go now; let's see if the CI and you agree with that ;) |
Looks all right, thanks |
Description
This adds
libtatsu
, a new library by theimobiledevice
project that is required to build latestidevicerestore
(https://github.com/libimobiledevice/libtatsu/).Type(s)
Tested on
macOS 15.1.1 24B2091 arm64
Xcode 16.2 16C5032a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?