Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtatsu: Add port. #27258

Merged
merged 1 commit into from
Jan 6, 2025
Merged

libtatsu: Add port. #27258

merged 1 commit into from
Jan 6, 2025

Conversation

turbocool3r
Copy link
Contributor

Description

This adds libtatsu, a new library by the imobiledevice project that is required to build latest idevicerestore (https://github.com/libimobiledevice/libtatsu/).

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1.1 24B2091 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@turbocool3r turbocool3r force-pushed the add-libtatsu branch 2 times, most recently from 619ba21 to f1419c1 Compare January 2, 2025 12:20
@turbocool3r
Copy link
Contributor Author

Sorry, had some problems with the devel variant, fixing it.

@turbocool3r
Copy link
Contributor Author

libplist-devel is way too old it seems, needs to be at list this commit.

@turbocool3r
Copy link
Contributor Author

Seems to be ok to merge now.

}

if {${subport} eq ${name}} {
conflicts libirecovery-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be "libtatsu-devel"? Also, I don't think it doesn't need to be in this block, it can just go up close to the "name" field - right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, missed that one. do you mean I should move it up in the file? that part wasn't changed a lot from the libirecovery portfile, libplist portfile https://github.com/macports/macports-ports/blob/master/textproc/libplist/Portfile seems to do this in a similar way. I'm open to changes though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the name fix for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, move it up to under the "name" field. Double check that it works correctly, but it should

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it up, but now for some reason my local port lint is unhappy about libtatsu-devel port not being known. CI seems to like everything.

devel/libtatsu/Portfile Outdated Show resolved Hide resolved
}

if {${subport} eq ${name}} {
conflicts libirecovery-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, move it up to under the "name" field. Double check that it works correctly, but it should

@turbocool3r turbocool3r force-pushed the add-libtatsu branch 2 times, most recently from b697eb0 to d1c79e7 Compare January 3, 2025 14:11
@turbocool3r
Copy link
Contributor Author

I've also changed it to act more like libplist's port to save some build time by not running autogen.sh for releases.

@reneeotten
Copy link
Contributor

@turbocool3r I did take a look at this PR locally and made a few changes. I think this should be good to go now; let's see if the CI and you agree with that ;)

@turbocool3r
Copy link
Contributor Author

Looks all right, thanks

@reneeotten reneeotten merged commit 1c6e2cc into macports:master Jan 6, 2025
3 checks passed
@turbocool3r turbocool3r deleted the add-libtatsu branch January 6, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants