Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legcord: new port #27235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

legcord: new port #27235

wants to merge 1 commit into from

Conversation

akierig
Copy link
Contributor

@akierig akierig commented Dec 30, 2024

Description

Legcord (originally Armcord) is a version of the Discord web client packaged for desktop. Unlike the Discord application or web client, it blocks Discord's trackers and consumes far fewer resources. It also supports all of the major Discord client plugin/theming frameworks.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.2 24C101 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@akierig akierig marked this pull request as ready for review December 30, 2024 12:11
@akierig
Copy link
Contributor Author

akierig commented Dec 30, 2024

advice would be appreciated here please.

tl;dr: it builds a .app in the location dist/mac-${build_arch} folder. on ARM machines, this is mac-arm64 unfortunately on x86 (at least per the github builder logs) this comes out to mac-x86_64 but the electron-builder folder is just mac-x86.

should I add in some 'if build_arch is x86_64 then move it from mac-x86' or similar?

@akierig
Copy link
Contributor Author

akierig commented Dec 31, 2024

I was privately reminded that legcord was originally designed and is optimized for arm64/aarch64 and have therefore restricted it to arm64 only.


github.setup Legcord Legcord 1.0.6 v
github.tarball_from archive
distname ${github.project}-${github.version}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the default not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't the first time I tried it, but just trying it now, it does just fine. Must have been something I was doing. Yanked the 'archive' line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the “github,tarball_from” line; the “distname” should be redundabt I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, for some reason it works inconsistently on ...from releases. so I switched back to archive and yanked the distname line.

sorry for the running around in circles.

@akierig akierig force-pushed the legcord branch 2 times, most recently from 5a8a4f7 to 1dc751b Compare January 10, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants