Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-rstan: fix older systems with libc++ #24545

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

Fix this finally too.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.8.5
Xcode 5.1.1

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156 barracuda156 marked this pull request as draft June 18, 2024 21:39
@barracuda156
Copy link
Contributor Author

P. S. The fix itself works fine and solves the problem, but it is suboptimal in a sense we will need to patch every dependent of RcppParallel in a same manner to fix them on older Intel systems.

Issue with upsteam: RcppCore/RcppParallel#219

@barracuda156
Copy link
Contributor Author

I want to fix this from RcppParallel side instead of patching multiple dependents, therefore closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants