Fix BuildTarget mapping for macOS and StandaloneOSX

machinezone · Aug 11, 2022 · 8dfc118 · 8dfc118
1 parent 85e91bd
commit 8dfc118
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/mac-build-tests.yml b/.github/workflows/mac-build-tests.yml
@@ -21,6 +21,7 @@ jobs:
           - 2020.3.24f1
         targetPlatform:
           - StandaloneOSX # Build a MacOS executable
+          - iOS
 
     steps:
       ###########################
@@ -36,9 +37,9 @@ jobs:
       - uses: actions/cache@v2
         with:
           path: ${{ matrix.projectPath }}/Library
-          key: Library-${{ matrix.projectPath }}-macos-${{ matrix.targetPlatform }}
+          key: Library-${{ matrix.projectPath }}-${{ runner.os }}-${{ matrix.targetPlatform }}
           restore-keys: |
-            Library-${{ matrix.projectPath }}-macos-
+            Library-${{ matrix.projectPath }}-${{ runner.os }}-
             Library-
 
       ###########################
@@ -69,6 +70,6 @@ jobs:
       ###########################
       - uses: actions/upload-artifact@v2
         with:
-          name: Build MacOS (${{ matrix.unityVersion }})
+          name: Build ${{ matrix.targetPlatform }} (${{ matrix.unityVersion }})
           path: build
           retention-days: 14
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/model/platform-setup/setup-mac.ts b/src/model/platform-setup/setup-mac.ts
@@ -42,13 +42,15 @@ class SetupMac {
       case 'Android':
         command += '--module android ';
         break;
-      case 'MacOS':
+      case 'StandaloneOSX':
         command += '--module mac-il2cpp ';
         break;
       case 'WebGL':
         command += '--module webgl ';
         break;
       default:
+        // Consider adding support for all valid targetPlatforms
+        // https://docs.unity3d.com/ScriptReference/BuildTarget.html
         throw new Error(`Unsupported module for target platform: ${targetPlatform}.`);
     }