GDPR replacements from JSON file #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
reviewed
Oct 12, 2018
src/Command/DumpCommand.php
Outdated
| @@ -343,6 +354,7 @@ protected function getDumpSettingsDefault() | |||
| ] + [ | |||
| 'gdpr-expressions' => null, | |||
| 'gdpr-replacements' => null, | |||
| 'gdpr-replacements-file' => null, | |||
There was a problem hiding this comment.
So it's not obvious, but this is possibly the reason you're rereading the file contents of your gdpr-replacements-file in /src/MysqldumpGdpr.php.
If you remove this line, you can also remove the lines 38-42 in MysqldumpGdpr.php.
src/MysqldumpGdpr.php
Outdated
| @@ -35,6 +35,11 @@ public function __construct( | |||
| unset($dumpSettings['gdpr-replacements']); | |||
| } | |||
|
|
|||
| if (array_key_exists('gdpr-replacements-file', $dumpSettings)) { | |||
There was a problem hiding this comment.
You're actually doing double work for yourself here - since you've already read and have passed in the data via the $dumpsettings variable. So I'd say, let's remove this as well.
|
Thank You for the review! Suggested fix added |
|
I have to close and reopen this one since i shouldn't have created PR from master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows GDPR replacement reading pattern from a JSON file. Editing mysql ini is a bit inconvenient so I made an option to read those from file.
You can use the same JSON structure you would for the
--gdpr-replacementsoption.