Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fonts #85

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

CaptainDolphy
Copy link
Contributor

I think #68 is a nice feature to have

here is a menu that will be used to set the fonts:
image
I can currently search for any system font installed, show/hide the search and select a font, though it's not yet setting a preview at the bottom and not changing the actual font in-game, I think the menu can later be useful for setting separate fonts even for mathML figuers #67.

Nonetheless this is a work-in-progress so setting to Draft

@m4ym4y
Copy link
Owner

m4ym4y commented Mar 8, 2025

This is an awesome idea! I was thinking, could we call this section of the menu "Accessibility"? then future accessibility settings (other settings that might make things more readable for example) can be put under that menu as well.

@CaptainDolphy
Copy link
Contributor Author

Yeah, great idea. Though I would make Fonts a separate section of Accessibility as I think it will get crowded otherwise. Btw I noticed some code for a narrator feature in main, settings for this (stuff like picking voices etc.) could also go into Accessibility.

Lastly just a stylistic question, should the font names already be in the font like shown or just appear in the preview. Honestly I think its a bit better when they show in the preview as some fonts use symbols for letters that would be tough to search for when you dont know the font name

@m4ym4y
Copy link
Owner

m4ym4y commented Mar 8, 2025

Maybe the preview could be inline with the font name in the list? So like "Name - example text in font"? That way the user doesn't need to select one font at a time to see which one they like.

And true, if we add more accessibility features we might want to add a sub-menu for going through accessibility options

@m4ym4y
Copy link
Owner

m4ym4y commented Mar 8, 2025

As for the narrator feature that's definitely something that could be enabled in accessibility! I tried having it on by default for a bit but the default voices are just awful sounding on most systems. But if it's opt in for people who want it for accessibility reasons it could definitely be revived

@CaptainDolphy
Copy link
Contributor Author

Actually I think having the font names in the fonts might just be fine as if you know the name you'll find the font you want, otherwise I would keep the preview down the bottom as if it was inline it wouldn't really fit. So if you want to quickly find the font you like, you'll get an idea from the name and upon clicking it, the preview will be shown providing more detail and more symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants