Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional changes to resolve outstanding comments #3

Merged

Conversation

seanankenbruck
Copy link

@seanankenbruck seanankenbruck commented Mar 3, 2025

What this PR does

This PR attempts to resolve remaining outstanding comments regarding rollout operator configurations for the Mimir helm chart.

  • resolves outstanding comments
  • updates tests

Which issue(s) this PR fixes or relates to

Fixes #7726

Existing PR: grafana#6733

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@seanankenbruck
Copy link
Author

@m1rp for your review

Copy link
Owner

@m1rp m1rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@m1rp m1rp merged commit d415a93 into m1rp:rollout-operator-config Mar 4, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants