Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to SQLAlchemy v2, add optimizations #70

Merged
merged 14 commits into from
Jun 16, 2023
Merged

Move to SQLAlchemy v2, add optimizations #70

merged 14 commits into from
Jun 16, 2023

Conversation

m-rtijn
Copy link
Owner

@m-rtijn m-rtijn commented Jun 12, 2023

Closes #67

@m-rtijn m-rtijn added the enhancement New feature or request label Jun 12, 2023
@m-rtijn m-rtijn self-assigned this Jun 12, 2023
@m-rtijn m-rtijn marked this pull request as draft June 12, 2023 17:58
@m-rtijn m-rtijn marked this pull request as ready for review June 12, 2023 19:57
@m-rtijn
Copy link
Owner Author

m-rtijn commented Jun 12, 2023

Todo:

  • evaluate index performance, check which are required
  • see if some things can be changed into more efficient queries (possibly with extra indexes)

@m-rtijn m-rtijn requested a review from tweska June 12, 2023 19:58
@m-rtijn m-rtijn changed the title Move to SQLAlchemy v2 Move to SQLAlchemy v2, add optimizations Jun 15, 2023
@m-rtijn
Copy link
Owner Author

m-rtijn commented Jun 15, 2023 •
edited
Loading

Page load times are significantly reduced now, this is quite some progress for #56

tweska
tweska previously approved these changes Jun 15, 2023
View reviewed changes
@m-rtijn m-rtijn merged commit 881b810 into master Jun 16, 2023
@m-rtijn m-rtijn deleted the sqlalchemy-v2 branch June 16, 2023 13:28
@m-rtijn m-rtijn mentioned this pull request Jun 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tweska tweska tweska left review comments

Assignees

@m-rtijn m-rtijn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to SQLAlchemy 2.0
2 participants
@m-rtijn @tweska