gomod: Update dependencies #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really an issue though as the CVE is about causing a DoS attack, typically on an online service. |
|
Looks like there's a syntax issue with the import changes. Can you also split things to have the change to the import (gopkg -> github) be its own commit so it's nicely split from the mechanical update of the go.mod. |
alexandrevicenzi
force-pushed
the
CVE-2024-45338
branch
from
49b4c90 to
3fa9fd8
Compare
|
@stgraber Thanks for reviewing. Sorry that I missed the static checks, it should be properly formatted now. |
stgraber
force-pushed
the
CVE-2024-45338
branch
from
3fa9fd8 to
5296943
Compare
Signed-off-by: Stéphane Graber <[email protected]>
replace gopkg.in/antchfx/htmlquery.v1 with github.com/antchfx/htmlquery Signed-off-by: Alexandre Vicenzi <[email protected]>
gopkg.in/antchfx/htmlquery.v1 v1.2.2 is affected by GO-2024-3333, bumping to v.1.3.4 fixes the security issue. Signed-off-by: Alexandre Vicenzi <[email protected]>
stgraber
force-pushed
the
CVE-2024-45338
branch
from
5296943 to
79a65d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gopkg.in/antchfx/htmlquery.v1 v1.2.2 is affected by GO-2024-3333, bumping to v.1.3.4 fixes the security issue.