Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tag instead of Version in goreleaser config #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awilmore
Copy link
Contributor

@awilmore awilmore commented Jun 5, 2024

Hi @lwolf , this is just a small change, but we are hoping the next image, v0.8.5, will be created as a cross-platform image (the current v0.8.4 image seems to be x86 only).

@lwolf
Copy link
Owner

lwolf commented Jun 6, 2024

Can you explain how this change supposed to fix the issue?

@awilmore
Copy link
Contributor Author

awilmore commented Jun 7, 2024

Can you explain how this change supposed to fix the issue?

There is no issue with the goreleaser config as it is. This PR just switches to using {{ .Tag }} instead of v{{ .Version }}.

The actual issue is that when the v0.8.4 tag was created, a cross-compiled 0.8.4 image was released by the Github action. But somehow a v0.8.4 image was also released, which is actually just a retagged version of the 0.8.4-amd64 image:

image

So this PR is a very minor change, and it is more about the next release, v0.8.5, which should hopefully show up in quay.io as a normal manifest wrapping the amd64 and arm64 images.

@lwolf
Copy link
Owner

lwolf commented Jun 7, 2024

I manually retagged 0.8.4 into v0.8.4 before adding this change 538f00d
I believe next tag should be good anyway.

@awilmore
Copy link
Contributor Author

@lwolf if this is okay to merge and tag, we will be able to see if the next release is cross-compiled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants