Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loguru & better path handling #132

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Add loguru & better path handling #132

merged 7 commits into from
Feb 19, 2025

Conversation

HonzaCuhel
Copy link
Contributor

Purpose

Ensure compatibility with the latest luxonis-ml version, improve the comfort of the usage, and enhance testing coverage.

Specification

  • Improvement of the submodules loading so that the toolkit can be run from whatever folder (previously for some models, it was required to run the toolkit from the root folder of the project)
  • Addition of luxonis-ml logging to unify the logging across our packages

Dependencies & Potential Impact

  • Dependency update to luxonis-ml >=0.6.1.
  • Dependency update to torch >=2.0.0.
  • Add depencies loguru>=0.7.0 and luxonis-ml[utils]

Deployment Plan

  • Update tools-cli plugin
  • Test on DEV/STG
  • Deploy

Testing & Validation

  • Tested locally

@HonzaCuhel HonzaCuhel self-assigned this Feb 17, 2025
@HonzaCuhel HonzaCuhel marked this pull request as draft February 17, 2025 09:22
Copy link

github-actions bot commented Feb 17, 2025

Test Results

  6 files    6 suites   8m 39s ⏱️
 24 tests  24 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit d100169.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 17, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22114 4808 22% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
tools/main.py 0% 🟢
tools/yolo/yolov10_exporter.py 84% 🟢
tools/yolo/yolov5_exporter.py 0% 🟢
tools/yolo/yolov6_exporter.py 85% 🟢
tools/yolo/yolov8_exporter.py 88% 🟢
tools/yolov7/yolov7_exporter.py 82% 🟢
TOTAL 56% 🟢

updated for commit: d100169 by action🐍

@HonzaCuhel HonzaCuhel marked this pull request as ready for review February 18, 2025 09:57
Copy link

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, otherwise LGTM.

@HonzaCuhel HonzaCuhel merged commit 50523f2 into main Feb 19, 2025
9 checks passed
@HonzaCuhel HonzaCuhel deleted the feat/add-loguru-paths branch February 19, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants