Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Making both web ports configurable flags #8

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

HarryStericker
Copy link
Contributor

Port 80 requires root privs, which is not ideal. Lets use a similar port - i vote for 8008 somewhat arbitrarily. Happy to discuss.

For External Submissions:

  • Have you followed the guidelines in our Contributing file?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If it's a non-trivial change, I've linked a new or existing issue to this PR
  • I have performed a self-review of my code
  • Does your submission pass existing tests?
  • Have you written new tests for your new changes, if applicable?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Port 80 requires root privs, which is not ideal. Lets use a similar port - i vote for 8008 somewhat arbitrarily. Happy to discuss.
server/main.go Outdated Show resolved Hide resolved
@echarrod
Copy link
Contributor

Looks like tests are succeeding for go1.22 but failing for go1.23.5 🤔

@HarryStericker HarryStericker changed the title server: Changing port to listen from 80 -> 8008 server: Making both web ports configurable flags Jan 29, 2025
@adamhicks adamhicks merged commit f1fba82 into luno:main Jan 29, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants