This PR will be a mix and match of small changes to docs and code with some fixes. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olves an inheritance issue.
…nge, result unchanged.
lukasturcani
approved these changes
Nov 7, 2023
tests/molecular/molecules/building_block/fixtures/init_from_file.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #155 #187 #477 #481 #515 #494 #514
Requested Reviewers: @lukasturcani
As in the title, many small changes and fixes.
Cof.pyand inheriting classes, andnrotaxane.py. This requires some help and explanation.self._scale_multiplierin Cage topologies.stk.polymer.Linear.html:orientations [list][[float] – For each character in the repeating unit, a value between 0 and 1 (both inclusive) must be given in a [tuple](tuple or list?)Questions:
Topology Graph Componentsdocs page - do we want to add all the different classes of vertex and edge?tupleoption because it makes far less sense for metal complexes than for cages to expectstkto figure out where to place building blocks.