Skip to content

Commit

Permalink
Cleaning up for Crystal 1.0 support (#126)
Browse files Browse the repository at this point in the history
* Updating crystal version constraint for allowing through 1.0. Cleaning up CI with matrix

* flip these two steps so the cache doesn't overwrite the shards

* bump shards for compatibility

* using alpine now means no apt-get

* we don't actually need to use alpine. Trying without it
  • Loading branch information
jwoertink authored Mar 29, 2021
1 parent 4f0cf68 commit 8b1a143
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 25 deletions.
54 changes: 35 additions & 19 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,49 @@ on:

jobs:
check_format:
strategy:
fail-fast: false
matrix:
crystal_version:
- 0.36.1
- 1.0.0
experimental:
- false
runs-on: ubuntu-latest
container:
image: crystallang/crystal:0.36.1
continue-on-error: ${{ matrix.experimental }}
container: crystallang/crystal:${{ matrix.crystal_version }}
steps:
- uses: actions/checkout@v1
- name: Install shards
run: shards install
- name: Format
run: crystal tool format --check
- name: Lint
run: bin/ameba
run: ./bin/ameba
specs:
strategy:
fail-fast: false
matrix:
crystal_version:
- 0.36.1
- 1.0.0
experimental:
- false
runs-on: ubuntu-latest
container:
image: crystallang/crystal:0.36.1
continue-on-error: ${{ matrix.experimental }}
container: crystallang/crystal:${{ matrix.crystal_version }}
steps:
- uses: actions/checkout@v2
- name: Install Chromedriver
run: |
apt-get update
apt-get -yqq install chromium-chromedriver
- name: Install shards
run: shards install
- name: Cache Crystal
uses: actions/cache@v1
with:
path: ~/.cache/crystal
key: ${{ runner.os }}-crystal
- name: Run tests
run: crystal spec
- uses: actions/checkout@v2
- name: Install Chromedriver
run: |
apt-get update
apt-get -yqq install chromium-chromedriver
- name: Cache Crystal
uses: actions/cache@v1
with:
path: ~/.cache/crystal
key: ${{ runner.os }}-crystal
- name: Install shards
run: shards install
- name: Run tests
run: crystal spec
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM crystallang/crystal:0.36.1
FROM crystallang/crystal:1.0.0
WORKDIR /data
EXPOSE 3002

Expand Down
10 changes: 5 additions & 5 deletions shard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ version: 0.7.2
authors:
- Paul Smith <[email protected]>

crystal: 0.36.1
crystal: ">= 0.36.1, < 2.0.0"

license: MIT

dependencies:
selenium:
github: matthewmcgarvey/selenium.cr
version: ~> 0.9.0
version: ~> 0.9.1
webdrivers:
github: matthewmcgarvey/webdrivers.cr
version: ~> 0.3.0
version: ~> 0.4.0
habitat:
github: luckyframework/habitat
version: ~> 0.4.4
version: ~> 0.4.7
development_dependencies:
ameba:
github: crystal-ameba/ameba
version: ~> 0.13
version: ~> 0.13.4

0 comments on commit 8b1a143

Please sign in to comment.