remove check playwright in init #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaromagnoli
added a commit
that referenced
this pull request
Nov 7, 2024
* Py313 (#56) * use Run CI workflow name * run 3.13 tests * update poetry.lock * add python version icons * poetry version minor * Async dataservice (#60) * AsyncDataService * minor version * remove DataItem from __all__ * Playwright optional (#61) * make playwright optional * update README.rst * minor version * Boilerplate (#62) * add cli tool * add py to filename if not present * update cli and template.py.j2 * remove check playwright in init (#63) * refactor Playwright,add PW config and devices.py * init page to None * fix playwright tests * change log.info to debug * add debug log messages * improve logs * change log level * add test_init_browser * add intercept_content_type * update publish.yml * update publish.yml for dev * update ci * fix pyproject.toml * update deps
lucaromagnoli
added a commit
that referenced
this pull request
Nov 7, 2024
* Py313 (#56) * use Run CI workflow name * run 3.13 tests * update poetry.lock * add python version icons * poetry version minor * Async dataservice (#60) * AsyncDataService * minor version * remove DataItem from __all__ * Playwright optional (#61) * make playwright optional * update README.rst * minor version * Boilerplate (#62) * add cli tool * add py to filename if not present * update cli and template.py.j2 * remove check playwright in init (#63) * refactor Playwright,add PW config and devices.py * init page to None * fix playwright tests * change log.info to debug * add debug log messages * improve logs * change log level * add test_init_browser * add intercept_content_type * update publish.yml * update publish.yml for dev * update ci * fix pyproject.toml * update deps * update workflow name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.