move timeout to client (#88)

lucaromagnoli · Nov 15, 2024 · 54c532d · 54c532d
1 parent f53aafa
commit 54c532d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/dataservice/clients.py b/dataservice/clients.py
@@ -263,7 +263,8 @@ async def _make_request(self, request: Request) -> Response:
 
         try:
             logger.debug(f"Requesting {request.url_encoded}")
-            pw_response = await page.goto(request.url)
+            # Playwright page.goto() timeout is in milliseconds
+            pw_response = await page.goto(request.url, timeout=request.timeout * 1000)
             logger.debug(f"Received response for {request.url_encoded}")
             self._raise_for_status(pw_response.status, pw_response.status_text)
 

diff --git a/dataservice/config.py b/dataservice/config.py
@@ -101,9 +101,6 @@ class ServiceConfig(BaseModel):
     delay: DelayConfig = Field(
         description="The delay configuration", default_factory=DelayConfig
     )
-    timeout: Seconds = Field(
-        default=Seconds(30), description="The timeout for requests in seconds."
-    )
 
 
 class ProxyConfig(BaseModel):

diff --git a/pyproject.toml b/pyproject.toml
@@ -3,7 +3,7 @@ name = "python-dataservice"
 packages = [
     { include = "dataservice"},
 ]
-version = "0.11.9"
+version = "0.11.10"
 description = "Lightweight async data gathering for Python"
 authors = ["NomadMonad <[email protected]>"]
 readme = "README.rst"