DM-48404 : Refactor Github Actions #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcjennings
force-pushed
the
tickets/DM-48099/v0.2.0
branch
from
e6bcb19 to
1307807
Compare
tcjennings
force-pushed
the
tickets/DM-48099/gh_actions
branch
3 times, most recently
from
bf693d4 to
39c9d95
Compare
tcjennings
changed the title
tcjennings
force-pushed
the
tickets/DM-48099/v0.2.0
branch
from
cc3d442 to
016065a
Compare
tcjennings
force-pushed
the
tickets/DM-48099/gh_actions
branch
from
39c9d95 to
0777889
Compare
tcjennings
force-pushed
the
tickets/DM-48099/gh_actions
branch
from
0777889 to
a09f00e
Compare
kherner
reviewed
Jan 15, 2025
| needs: | ||
| - ci | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 |
There was a problem hiding this comment.
Is there any reasonable situation in which 20 minutes wouldn't be enough? Probably not but worth thinking about for a minute if you didn't already.
There was a problem hiding this comment.
I think this is an inherited value from ultimately a square template, but it is a reasonable value if a bit long. 20 minutes would be an eternity for a build.
kherner
approved these changes
Jan 15, 2025
tcjennings
force-pushed
the
tickets/DM-48099/gh_actions
branch
from
a09f00e to
90161ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits GitHub actions into separate workflows:
CI - runs lint, typing, and tests for any push to an active branch.
Release - runs python-semantic-release when a PR is merged to main. This includes bumping the project version and writing a tag.
Build-Push - performs docker container build operations when a tagged release is made or when an active ticket branch is part of a PR.