DM-47879: Write characterization report for 28.0.0 Science Pipelines Release #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leannep
requested changes
Jan 23, 2025
DMTR-451.tex
Outdated
|
|
||
| \item The synthetic source injection package is now included in lsst\_distrib. This update is accompanied by documentation that provides detailed instructions on how to use it and an FAQ. | ||
| \item Compensated tophats for photoCalib (DM-38632), used in CalibrateImageTask (DM-44908). | ||
| \item DM-44130 change default S/N cut for PSF star selection from 20 to 50. |
There was a problem hiding this comment.
Suggested change
| \item DM-44130 change default S/N cut for PSF star selection from 20 to 50. | |
| \item DM-44130 Change default S/N cut for PSF star selection from 20 to 50. |
There was a problem hiding this comment.
These bullets needed editing anyway -- hopefully they are clearer now.
DMTR-451.tex
Outdated
| \end{itemize} | ||
|
|
||
| Photometry and astrometry metrics reported here were calculated using the \href{https://github.com/lsst/analysis_tools}{analysis\_tools} package, which is part of the standard pipeline distribution. The \texttt{analysis\_tools} package builds on and supersedes \href{https://github.com/lsst/faro}{faro} (\citeds{DMTN-211}), which has been used for the past few years. The calculation of most metrics reported in this Report is unchanged between the two packages, though minor differences are to be expected because of fundamental differences in the underlying data-handling frameworks. As discussed in the next section, the photometric outlier fraction PF1 has been updated relative to previous pipeline release versions in order to fix a mistake in how the calculation was implemented. We are actively working on a revised definition of the residual ellipticity correlation metrics TE1 and TE2, to be implemented in \texttt{analysis\_tools}. Because this work is still in progress, the ellipticity metrics reported here are calculated by \texttt{faro} in the same manner as previous versions of the Characterization Metric Report. | ||
| Photometry and astrometry metrics reported here were calculated using the \href{https://github.com/lsst/analysis_tools}{analysis\_tools} package, which is part of the standard pipeline distribution. The \texttt{analysis\_tools} package builds on and supersedes \href{https://github.com/lsst/faro}{faro} (\citeds{DMTN-211}), which has been used for the past few years. The calculation of most metrics reported in this Report is unchanged between the two packages, though minor differences are to be expected because of fundamental differences in the underlying data-handling frameworks. We are actively working on a revised definition of the residual ellipticity correlation metrics TE1 and TE2, to be implemented in \texttt{analysis\_tools}. Because this work is still in progress, the ellipticity metrics reported here are calculated by \texttt{faro} in the same manner as previous versions of the Characterization Metric Report. |
There was a problem hiding this comment.
"though minor differences are to be expected because of fundamental differences in the underlying data-handling frameworks." -- Written like this, it seems to imply that the frameworks themselves influence the results, which should not be the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.