Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfaSelect return at least ip of same protocol of dest addr #926

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

vanonox
Copy link
Contributor

@vanonox vanonox commented Jan 9, 2025

issue raised here #925

the source ip used for check the endpoints is retrieved with using IfaSelect
IfaSelect currently return as a fallback solution the first ip of the interface
it should a least return an ip of the same protocol of the addr targeted so the endpoints can be checked

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025

CLA assistant check
All committers have signed the CLA.

@vanonox vanonox force-pushed the selectSameProtocol branch from 00fef15 to 179ab17 Compare January 9, 2025 19:55
@vanonox vanonox force-pushed the selectSameProtocol branch from 179ab17 to 0f9ca57 Compare January 9, 2025 20:09
Copy link
Collaborator

@TrekkieCoder TrekkieCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@TrekkieCoder TrekkieCoder merged commit e50e998 into loxilb-io:main Jan 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants