check response http status code

loxilb-io · Dec 12, 2023 · dbb8007 · dbb8007
1 parent e1cb1b8
commit dbb8007
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/pkg/agent/manager/loadbalancer/loadbalancer.go b/pkg/agent/manager/loadbalancer/loadbalancer.go
@@ -760,16 +760,17 @@ func (m *Manager) deleteLoadBalancer(ns, name string) error {
 			}(loxiClient, ch)
 		}
 
+		var err error
 		isError := true
 		for _, errCh := range errChList {
-			err := <-errCh
+			err = <-errCh
 			if err == nil {
 				isError = false
 				break
 			}
 		}
 		if isError {
-			return fmt.Errorf("failed to delete loxiLB LoadBalancer")
+			return fmt.Errorf("failed to delete loxiLB LoadBalancer. err: %v", err)
 		}
 		if lb.inRange {
 			ipPool.ReturnIPAddr(lb.LbModel.Service.ExternalIP, lb.IdentIPAM)

diff --git a/pkg/api/request.go b/pkg/api/request.go
@@ -119,22 +119,26 @@ func (l *LoxiRequest) Do(ctx context.Context) *LoxiResponse {
 
 	resp, err := l.client.Client.Do(req)
 	if err != nil {
-		return &LoxiResponse{err: err}
+		statusCode := 0
+		if resp != nil {
+			statusCode = resp.StatusCode
+		}
+		return &LoxiResponse{statusCode: statusCode, err: err}
 	}
 
 	defer resp.Body.Close()
 	respByte, err := io.ReadAll(resp.Body)
 	if err != nil {
-		return &LoxiResponse{err: err}
+		return &LoxiResponse{statusCode: resp.StatusCode, err: err}
 	}
 
 	if resp.StatusCode == http.StatusOK {
 		if err := json.Unmarshal(respByte, &result); err != nil {
-			return &LoxiResponse{err: err}
+			return &LoxiResponse{statusCode: resp.StatusCode, err: err}
 		}
 
 		if result.Result != "Success" {
-			return &LoxiResponse{err: errors.New(result.Result)}
+			return &LoxiResponse{statusCode: resp.StatusCode, err: errors.New(result.Result)}
 		}
 	}