Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails deprecation warnings (use after_commit -> { }) #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix rails deprecation warnings (use after_commit -> { }) #92

wants to merge 2 commits into from

Conversation

sergeykish
Copy link

Hello

That's part of the rails 5 deprecation warnings cleanup.
It fixes DEPRECATION WARNING: Passing string to define callback.
Change is almost mechanical and I hope new lambda syntax is quite old already (ruby 1.9).

I've also noticed specs failure with rspec 3, changed gemspec to use rspec 2 instead.

@sergeykish
Copy link
Author

@lostboy any problem with this pull request?

@unmultimedio
Copy link
Contributor

@sergeykish This repo seems really inactive. Any thoughts on mantaining your own version with Rails 5 deprecation cleanup, and 5.1 support?

@lostboy
Copy link
Owner

lostboy commented Aug 30, 2017

Hey guys, I've left this for so long, apologies for going awol. If people are still keen I can put some time to bringing the repo and gem up to speed.

@unmultimedio
Copy link
Contributor

@lostboy glad you're back. I've checked this in depth couple of months ago, and I've found one fork that has been mantained and updated to work with Rails 5: https://github.com/davidakachaos/workless_revived & It's working ok!

I think you should talk to @davidakachaos to join efforts! Thanks for coming back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants