Skip to content

Commit

Permalink
Merge pull request #105 from huijing/main
Browse files Browse the repository at this point in the history
Fix dropdown menu button label issue
  • Loading branch information
lorenzolewis authored Oct 6, 2024
2 parents 66874b0 + fbe0f45 commit 4e1da13
Show file tree
Hide file tree
Showing 4 changed files with 231 additions and 264 deletions.
5 changes: 5 additions & 0 deletions .changeset/heavy-students-exercise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lorenzo_lewis/starlight-utils": minor
---

Support translated strings introduced in the Starlight 0.28 localization API
2 changes: 1 addition & 1 deletion packages/starlight-utils/components/Dropdown.astro
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface Props {
<starlight-multi-sidebar-select>
<label>
<span class="sr-only">
{Astro.props.starlightProps.labels["menuButton.accessibleLabel"]}
{Astro.locals.t("menuButton.accessibleLabel")}
</span>
<select>
{
Expand Down
4 changes: 2 additions & 2 deletions packages/starlight-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"astro": "^4.15.11"
},
"peerDependencies": {
"@astrojs/starlight": ">=0.16.0",
"astro": ">=4.0.0"
"@astrojs/starlight": ">=0.28.0",
"astro": ">=4.14.0"
},
"dependencies": {
"astro-integration-kit": "^0.16.1"
Expand Down
Loading

0 comments on commit 4e1da13

Please sign in to comment.