humble.rosidl-generator-py: Fix numpy include path #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past NumPy core headers were under numpy/core/include, but in recent nixpkgs versions, the location changed to numpy/_core/include. NumPy >= 2.0 also includes numpy-config tool. We could use the tool to get the correct path, instead of hardcoding it in the Nix expression, but I'm not sure how it would work with cross-compiling, so I'm leaving the logic as it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes many build failures when building the overlay against nixos-unstable.
In the past NumPy core headers were under
numpy/core/include, but in recent nixpkgs versions, the location changed tonumpy/_core/include.NumPy >= 2.0 also includes
numpy-configtool. We could use the tool to get the correct path, instead of hardcoding it in the Nix expression, but I'm not sure how it would work with cross-compiling, so I'm leaving the logic as it was.