Skip to content

Commit

Permalink
8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR
Browse files Browse the repository at this point in the history
Reviewed-by: erikj, jwilhelm
  • Loading branch information
jglick authored and JesperIRL committed Aug 10, 2023
1 parent 88b4e3b commit 42758cb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 29 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Contributing to the JDK

Please see <https://openjdk.org/contribute> for how to contribute.
Please see the [OpenJDK Developers’ Guide](https://openjdk.org/guide/).
19 changes: 5 additions & 14 deletions doc/building.html
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ <h3 id="building-on-x86">Building on x86</h3>
<p>Even for 32-bit builds, it is recommended to use a 64-bit build
machine, and instead create a 32-bit target using
<code>--with-target-bits=32</code>.</p>
<p>Note: The Windows 32-bit x86 port is deprecated and may be removed in a future release.</p>
<p>Note: The Windows 32-bit x86 port is deprecated and may be removed in
a future release.</p>
<h3 id="building-on-aarch64">Building on aarch64</h3>
<p>At a minimum, a machine with 8 cores is advisable, as well as 8 GB of
RAM. (The more cores to use, the more memory you need.) At least 6 GB of
Expand Down Expand Up @@ -401,7 +402,8 @@ <h3 id="windows">Windows</h3>
use <code>--with-msvcr-dll=/cygdrive/c/msvcr100.dll</code> rather than
<code>--with-msvcr-dll=c:\msvcr100.dll</code>. For details on this
conversion, see the section on <a href="#fixpath">Fixpath</a>.</p>
<p>Note: The Windows 32-bit x86 port is deprecated and may be removed in a future release.</p>
<p>Note: The Windows 32-bit x86 port is deprecated and may be removed in
a future release.</p>
<h4 id="cygwin">Cygwin</h4>
<p>A functioning <a href="http://www.cygwin.com/">Cygwin</a> environment
is required for building the JDK on Windows. If you have a 64-bit OS, we
Expand Down Expand Up @@ -2255,18 +2257,7 @@ <h2 id="contributing-to-the-jdk">Contributing to the JDK</h2>
must ask you to follow our rules and guidelines to be able to accept
your contribution.</p>
<p>The official place to start is the <a
href="http://openjdk.org/contribute/">'How to contribute' page</a>.
There is also an official (but somewhat outdated and skimpy on details)
<a href="http://openjdk.org/guide/">Developer's Guide</a>.</p>
<p>If this seems overwhelming to you, the Adoption Group is there to
help you! A good place to start is their <a
href="https://wiki.openjdk.org/display/Adoption/New+Contributor">'New
Contributor' page</a>, or start reading the comprehensive <a
href="https://adoptopenjdk.gitbooks.io/adoptopenjdk-getting-started-kit/en/">Getting
Started Kit</a>. The Adoption Group will also happily answer any
questions you have about contributing. Contact them by <a
href="http://mail.openjdk.org/mailman/listinfo/adoption-discuss">mail</a>
or <a href="http://openjdk.org/irc/">IRC</a>.</p>
href="https://openjdk.org/guide/">OpenJDK Developers’ Guide</a>.</p>
<h2 id="editing-this-document">Editing this document</h2>
<p>If you want to contribute changes to this document, edit
<code>doc/building.md</code> and then run
Expand Down
15 changes: 1 addition & 14 deletions doc/building.md
Original file line number Diff line number Diff line change
Expand Up @@ -2032,20 +2032,7 @@ First of all: Thank you! We gladly welcome your contribution.
However, please bear in mind that the JDK is a massive project, and we must ask
you to follow our rules and guidelines to be able to accept your contribution.
The official place to start is the ['How to contribute' page](
http://openjdk.org/contribute/). There is also an official (but somewhat
outdated and skimpy on details) [Developer's Guide](
http://openjdk.org/guide/).
If this seems overwhelming to you, the Adoption Group is there to help you! A
good place to start is their ['New Contributor' page](
https://wiki.openjdk.org/display/Adoption/New+Contributor), or start
reading the comprehensive [Getting Started Kit](
https://adoptopenjdk.gitbooks.io/adoptopenjdk-getting-started-kit/en/). The
Adoption Group will also happily answer any questions you have about
contributing. Contact them by [mail](
http://mail.openjdk.org/mailman/listinfo/adoption-discuss) or [IRC](
http://openjdk.org/irc/).
The official place to start is the [OpenJDK Developers’ Guide](https://openjdk.org/guide/).
## Editing this document
Expand Down

0 comments on commit 42758cb

Please sign in to comment.