Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade alpine from 3.20.1 to 3.21.2 #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade alpine from 3.20.1 to 3.21.2 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d0924
askpass
wmiller112 Jul 12, 2024
cfcfa7a
fix: Dockerfile to reduce vulnerabilities
snyk-bot Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN /build/scripts/deps.sh

RUN make plugin_versioned.yaml all -j4

FROM alpine:3.20.1
FROM alpine:3.21.2
ENV LOVELY_HELM_PATH=/usr/local/bin/helm
ENV LOVELY_HELMFILE_PATH=/usr/local/bin/helmfile
ENV LOVELY_KUSTOMIZE_PATH=/usr/local/bin/kustomize
Expand Down
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# FORK DETAILS

This plugin currently [does not support](https://github.com/crumbhole/argocd-lovely-plugin/issues/36) private repos. To work around this we can update the main.go with an os.getenv for the `GIT_ASKPASS` variable, which we pass in via a kubernetes secret. Currently just manually rebasing from the fork when new functionality is needed and then:

- Build and push image:
- `docker buildx build --platform linux/amd64 -t 717232957798.dkr.ecr.us-west-2.amazonaws.com/argocd-lovely-plugin:<tag> --push .`


# argocd-lovely-plugin
An [Argo CD](https://argoproj.github.io/argo-cd/) plugin that behaves in a way we wish Argo CD behaved. This is only aimed at using Argo CD for GitOps - we do not use the UI for creating or modifying applications.

Expand Down
1 change: 1 addition & 0 deletions cmd/argocd-lovely-plugin/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ func (c *Collection) doAllDirs(path string) (string, error) {
}

func main() {
os.Setenv("GIT_ASKPASS", "/usr/local/bin/git_askpass.sh")
dir, err := os.Getwd()
if err != nil {
log.Fatal(err)
Expand Down
Loading