Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup ci & release workflows, update readme #24

Merged

Conversation

yesudeep
Copy link

Changelog:

  • Setup CI and release workflows
  • Changes output directory to dist/
  • Updates README with new instructions
  • Deletes build artifacts.

@yesudeep yesudeep requested a review from a team as a code owner January 11, 2024 06:50
@yesudeep
Copy link
Author

@jeremytchang this one uses node version 18 and it appears that the CI system uses 16. How do we handle this situation?

Changelog:

- [ ] Setup CI and release workflows
- [ ] Changes output directory to dist/
- [ ] Updates README with new instructions
- [ ] Deletes build artifacts.
@yesudeep yesudeep force-pushed the yesudeep/chore/setup-ci branch from 4bddce5 to 0151fdd Compare February 15, 2024 17:25
Copy link

@andres-rubio-go andres-rubio-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yesudeep yesudeep merged commit 763a6b6 into looker-open-source:master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants