Dashboard colors and "Meta" string hardcoded changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CsarSainz
commented
Dec 19, 2024
CsarSainz
commented
- Changed colors from campaign manager dashboard in order to make more sense from Data Analytics perspective.
- Added "Meta" hardcoded as a string so identify this source instead of a syntethic data column we used before.
Itzaprado
reviewed
Dec 20, 2024
| @@ -15,7 +15,7 @@ sql: | |||
| ad_insights.CampaignName AS campaign_name, | |||
| ad_insights.AdSetId AS ad_set_id, | |||
| ad_insights.AdSetName AS ad_set_name, | |||
| ad_insights.meta_ads_source AS ad_source, | |||
| "Meta" AS ad_source, | |||
There was a problem hiding this comment.
ad_insights.meta_ads_source is a synthetic column we generated for testing purposes, not part of the original Meta data transfer.
The data transfer as far as I know doesn't have a column to identify "Instagram" or "Facebook", but we need to be able to check from which source this derived table is pulling data from regardless of that. That's because Meta derived table is part of the code to generate the multisource DT: https://github.com/looker-open-source/pacing-ads-block/blob/master/views/pacing_block/multisource_ads.view.lkml
Any more doubts feel free to ask.
Thanks!
Itzaprado
approved these changes
Dec 20, 2024
yesudeep
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.