Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use slashes in folder names instead of division slashes added by Gazer #153

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

drstrangelooker
Copy link
Contributor

When Gazer exports folders it replaces slashes with division slashes (Unicode character 2215) in the corresponding local folder name, and when Looker Deployer is importing content it's using the local folder names to create folders in the target Looker instance, which results in folders whose names contain slashes getting slightly mangled to contain division slashes when they're imported. This PR attempts to restore the original folder names containing normal slashes when importing.

Copy of #152 running from a local branch so tests run properly.

sean-rose and others added 3 commits December 4, 2024 09:01
@drstrangelooker drstrangelooker requested a review from a team as a code owner December 4, 2024 18:03
Copy link

github-actions bot commented Dec 4, 2024

Python Tests

    6 files  ±0  168 suites  ±0   2s ⏱️ ±0s
  89 tests ±0    89 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
429 runs  ±0  429 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9710a30. ± Comparison against base commit 9719386.

Co-authored-by: Sean Rose <[email protected]>
Copy link

github-actions bot commented Dec 4, 2024

Python Tests

    6 files  ±0  168 suites  ±0   2s ⏱️ ±0s
  89 tests ±0    89 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
429 runs  ±0  429 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5f6b2e5. ± Comparison against base commit 9719386.

@drstrangelooker drstrangelooker merged commit 94d3efb into main Dec 4, 2024
9 checks passed
@drstrangelooker drstrangelooker deleted the fix-folder-slashes branch December 4, 2024 18:32

This comment has been minimized.

@drstrangelooker drstrangelooker restored the fix-folder-slashes branch December 4, 2024 18:37
@drstrangelooker drstrangelooker deleted the fix-folder-slashes branch December 4, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants