Skip to content

Commit

Permalink
Merge pull request #210 from looker-open-source/issue-193
Browse files Browse the repository at this point in the history
Undo changes from 4.3.2
  • Loading branch information
fabio-looker authored Jan 3, 2025
2 parents fdf9e84 + 77a50d2 commit e4bc074
Show file tree
Hide file tree
Showing 11 changed files with 22 additions and 21 deletions.
3 changes: 2 additions & 1 deletion docs/release-notes/v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,5 @@ LookML Dashboards are now supported. This functionality is disabled by default.
Patches:

- v3.4.1 - Dependency updates in LAMS for jsonpath-plus. Dependency updates in Rule Sandbox for webpack and sub-dependencies.
- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut.
- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut.
- v3.4.3 - Reverts v3.4.2, leaving whitespace handling as-is. New whitespace handling will be introduced as a breaking change in v4.
18 changes: 9 additions & 9 deletions npm-shrinkwrap.dev.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"name": "@looker/look-at-me-sideways",
"version": "3.4.2",
"version": "3.4.3",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@looker/look-at-me-sideways",
"version": "3.4.2",
"version": "3.4.3",
"license": "MIT",
"dependencies": {
"dot": "^1.1.3",
"fromentries": "^1.3.2",
"jsonpath-plus": "^10.2.0",
"liyad": "^0.2.4",
"lookml-parser": "^6.11.0",
"lookml-parser": "^6.10.0",
"minimist": "^1.2.6",
"require-from-string": "^2.0.2"
},
Expand Down Expand Up @@ -3862,9 +3862,9 @@
"dev": true
},
"node_modules/lookml-parser": {
"version": "6.11.0",
"resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz",
"integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==",
"version": "6.10.0",
"resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz",
"integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==",
"dependencies": {
"bluebird": "^3.5.1",
"glob": "^7.1.2",
Expand Down Expand Up @@ -8052,9 +8052,9 @@
"dev": true
},
"lookml-parser": {
"version": "6.11.0",
"resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz",
"integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==",
"version": "6.10.0",
"resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz",
"integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==",
"requires": {
"bluebird": "^3.5.1",
"glob": "^7.1.2",
Expand Down
18 changes: 9 additions & 9 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@looker/look-at-me-sideways",
"version": "3.4.2",
"version": "3.4.3",
"description": "A judgmental little LookML linter >_>",
"main": "index.js",
"directories": {
Expand Down Expand Up @@ -39,7 +39,7 @@
"fromentries": "^1.3.2",
"jsonpath-plus": "^10.2.0",
"liyad": "^0.2.4",
"lookml-parser": "^6.11.0",
"lookml-parser": "^6.10.0",
"minimist": "^1.2.6",
"require-from-string": "^2.0.2"
},
Expand Down

0 comments on commit e4bc074

Please sign in to comment.