Whitespace changes as v4

looker-open-source · Jan 3, 2025 · 2d9dabc · 2d9dabc
1 parent 77a50d2
commit 2d9dabc
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -158,7 +158,7 @@ The manifest can provide the following declarations:
 ### Release Notes
 
 - [v2](https://looker-open-source.github.io/look-at-me-sideways/release-notes/v2)
-- [v3](https://looker-open-source.github.io/look-at-me-sideways/release-notes/v3)
+- [v3+](https://looker-open-source.github.io/look-at-me-sideways/release-notes/v3)
 
 ### Privacy Policy
 

diff --git a/...y-projects/.33-w1-tests/01-good.view.lkml → ...my-projects/33-w1-tests/01-good.view.lkml b/...y-projects/.33-w1-tests/01-good.view.lkml → ...my-projects/33-w1-tests/01-good.view.lkml
diff --git a/...my-projects/.33-w1-tests/02-bad.view.lkml → ...mmy-projects/33-w1-tests/02-bad.view.lkml b/...my-projects/.33-w1-tests/02-bad.view.lkml → ...mmy-projects/33-w1-tests/02-bad.view.lkml
diff --git a/...ests/03-old-cc-indented-nospace.view.lkml → ...ests/03-old-cc-indented-nospace.view.lkml b/...ests/03-old-cc-indented-nospace.view.lkml → ...ests/03-old-cc-indented-nospace.view.lkml
diff --git a/...-tests/04-new-cc-indented-space.view.lkml → ...-tests/04-new-cc-indented-space.view.lkml b/...-tests/04-new-cc-indented-space.view.lkml → ...-tests/04-new-cc-indented-space.view.lkml
diff --git a/...y-projects/.33-w1-tests/index.test.js.txt → .../dummy-projects/33-w1-tests/index.test.js b/...y-projects/.33-w1-tests/index.test.js.txt → .../dummy-projects/33-w1-tests/index.test.js
diff --git a/...dummy-projects/.33-w1-tests/manifest.lkml → .../dummy-projects/33-w1-tests/manifest.lkml b/...dummy-projects/.33-w1-tests/manifest.lkml → .../dummy-projects/33-w1-tests/manifest.lkml
diff --git a/...projects/.33-w1-tests/my_model.model.lkml → ...-projects/33-w1-tests/my_model.model.lkml b/...projects/.33-w1-tests/my_model.model.lkml → ...-projects/33-w1-tests/my_model.model.lkml
diff --git a/docs/release-notes/v3.md b/docs/release-notes/v3.md
@@ -101,4 +101,9 @@ Patches:
 
 - v3.4.1 - Dependency updates in LAMS for jsonpath-plus. Dependency updates in Rule Sandbox for webpack and sub-dependencies.
 - v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. 
-- v3.4.3 - Reverts v3.4.2, leaving whitespace handling as-is. New whitespace handling will be introduced as a breaking change in v4.
+- v3.4.3 - Reverts v3.4.2, leaving whitespace handling as-is. New whitespace handling will be introduced as a breaking change in v4.
+
+# v4
+
+v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. Conditional comments will preserve the whitespace before the comment, consume the comment character and up to one space or tab character following the comment character and/or conditional comment token.
+
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "fromentries": "^1.3.2",
     "jsonpath-plus": "^10.2.0",
     "liyad": "^0.2.4",
-    "lookml-parser": "^6.10.0",
+    "lookml-parser": "^6.11.0",
     "minimist": "^1.2.6",
     "require-from-string": "^2.0.2"
   },