Add html_escape so that code cannot be ran based on URL params
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lookbook-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is part of #669. The change attempts to ensure that the parameter value is properly escaped to prevent potential security vulnerabilities, such as XSS.
If the
escaped_valuecontains the following value or similar then it could lead to XSS:"-alert(window.location.href)-"- Theconsole.logwould be ran, as the quotes would evaluate toNaN, leaving the JavaScript within to be ran (i.e.paramsInputComponent({name: 'text', value: ""-alert(window.location.href)-""}).Example in Lookbook demo
Solution
The easiest workaround seemed to be parsing the string and removing instances of quotes. This can be done utilizing
html_escape, which removes special characters including quotes for more assurance. This shouldn't have any ill affects to how Lookbook processes params currently, as it'll only convert special characters to their HTML entity (e.g."to"), while retaining the actual value in the rendered UI.