Allow disabling of error handling #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue lookbook-hq#528 Allow opting out of catching errors in the application controller. Allows usage of web_console, better_errors, and other solutions.
✅ Deploy Preview for lookbook-docs canceled.
|
|
Hey @wheeyls, thank you for this! In a future major release of Lookbook it may be that not handling errors becomes the default behaviour as I've never been super happy with it. But having it as a config option for now is great. I'll just give it a try now but if I don't find any issues with it I'll merge it in, add a note in the docs and get it out in the next release. Thanks again :) |
|
Looks good, merging now - thanks again for the contribution! |
|
Thanks @allmarkedup.And yeah I agree as a rule I'd prefer the default behavior is to let me choose my error handling strategy myself, there are lots of other solutions out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #528
Allow opting out of catching errors in the application controller. Allows usage of web_console, better_errors, and other solutions.