v0.16.0, fix mustBeError test helper for nodeJS v10 assert changes

localnerve · Jun 7, 2019 · a584cfe · a584cfe
1 parent 6ecc72d
commit a584cfe
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/test/helpers/result.js b/test/helpers/result.js
@@ -5,12 +5,23 @@
  */
 var assert = require("assert");
 
-function mustBeError(err) {
+/**
+ * NodeJS v8 ifError throws if value is truthy
+ * NodeJS v10 ifError throws if value is NOT undefined or null.
+ * So to cover both, added falsy check.
+ *
+ * @param {*} err 
+ */
+function notFalsy (err) {
+  return !!err;
+}
+
+function mustBeError (err) {
   assert.throws(
-    function() {
-      assert.ifError(err);
+    function () {
+      notFalsy(err) && assert.ifError(err);
     },
-    function(err) {
+    function (err) {
       return !!err;
     }
   );