Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prompt Syntax Highlighter #463

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: Prompt Syntax Highlighter #463

merged 1 commit into from
Nov 22, 2023

Conversation

kaalibro
Copy link
Collaborator

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  • Fix #449
    In some very rare cases, highlighted syntax selection may still not work correctly. In such a case you just need to resize the textarea and everything will fall into place. Only relevant for "Resizable" textarea.
  • Added "BREAK" prompt keyword.
  • Highlighting colors slightly revamped for better readability: a little more focus on the tokens.
  • Fixed "numbers" regular expression so that they are not highlighted when they are part of a token.

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

numbers-regex

@kaalibro
fix: Prompt Syntax Highlighter
8fda68b 
Fix wrong syntax highlights.
Add "BREAK" keyword.
Fix "numbers" regular expression so that they are not highlighted when they are part of a token.
Highlighting colors slightly revamped for better readability: a little more focus on the tokens.
@lobehubbot
Copy link
Member

๐Ÿ‘ @kaalibro

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@canisminor1990 canisminor1990 merged commit cae4fe5 into lobehub:main Nov 22, 2023
3 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @kaalibro โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ!

@canisminor1990
Copy link
Member

โ™ฅ(๏ฝก๏ฟซv๏ฟฉ๏ฝก)โ™ฅ

@canisminor1990
Copy link
Member

@kaalibro Thank you for helping solve another headache-inducing problem.๐Ÿ‘๐Ÿ‘๐Ÿ‘

@kaalibro kaalibro deleted the syntax-highlighter branch November 22, 2023 21:41
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 3.0.12 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Prompt Section with wrong highlights
3 participants
@kaalibro @lobehubbot @canisminor1990