feat(MI-86): updating uploads/creatives API with personalized QR codes in campaigns #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaan-lob
changed the title
kevinpjones
approved these changes
Mar 1, 2024
shared/models/qr_code_campaigns.yml
Outdated
| description: | | ||
| Redirect all mail recipients to either a single URL or specify a unique URL for each recipient. | ||
| To redirect all mail recipients in a campaign to the same URL, assign the desired URL to this field. | ||
| To redirect each mail recipient to a unique URL, leave this field empty and specify the redirect link for each row in the audience file. Then, when creating a new upload, map this column to the `qr_code_redirect_url` key in the `mergeVariableColumnMapping` property. |
There was a problem hiding this comment.
Probably want to retain the help center link on audience file.
juanfriss
approved these changes
Mar 4, 2024
Hey @juanfriss, do we need to include output files from the |
|
I think you don't as "The bundled version is generated as part of CI/CD" |
|
I think you'll need |
Vulnerable Libraries (7)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MI-86
Functionality already exists, just updating copy to clarify how to use personalized QR codes per recipient in a campaign.
Checklist
mainnpm run bundleoutputs nothing suspectnpm run postmanoutputs nothing suspectChanges
Areas of Concern (optional)