Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMB-341: docs to support legal letters #481

Merged
merged 2 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lob-api-public.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
openapi: 3.0.3

Check warning on line 1 in lob-api-public.yml

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-valid-media-example

This format violates OpenAPI 3.1 rules
info:
title: Lob
version: 1.19.24
version: 1.19.25
description: |
The Lob API is organized around REST. Our API is designed to have predictable, resource-oriented URLs and uses HTTP response codes to indicate any API errors. <p>
license:
Expand Down Expand Up @@ -914,7 +914,7 @@
<div class="back-to-top" ><a href="#" onclick="toTopLink()">back to top</a></div>
- name: Getting Started
x-traitTag: true
description: |

Check warning on line 917 in lob-api-public.yml

View workflow job for this annotation

GitHub Actions / Lint (push)

no-script-tags-in-markdown

Markdown descriptions must not have "<script>" tags.
### 1. Get Setup
* Create an account at <a href="https://dashboard.lob.com/#/register" target="_blank">Lob.com</a>
* Obtain your API keys in the Lob dashboard <a href="https://dashboard.lob.com/settings/api-keys" target="_blank">settings</a>
Expand Down
35 changes: 31 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lob/openapi",
"version": "1.19.24",
"version": "1.19.25",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to upgrade package-lock.json too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably. I wasn't sure about committing the package-lock.json too. I'll push it.

"engines": {
"node": ">=14.16.0",
"npm": ">=7.9.0"
Expand Down
2 changes: 2 additions & 0 deletions resources/letters/attributes/extra_service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ description: |
* `certified` - track and confirm delivery for domestic destinations. An extra sheet (1 PDF page single-sided or 2 PDF pages double-sided) is added to the beginning of your letter for address and barcode information. See here for templates: <a href="https://s3-us-west-2.amazonaws.com/public.lob.com/assets/templates/letter_certified_template.pdf" target="_blank">#10 envelope</a> and <a href="https://s3-us-west-2.amazonaws.com/public.lob.com/assets/templates/letter_certified_flat_template.pdf" target="_blank">flat envelope</a> (used for letters over 6 pages single-sided or 12 pages double-sided). You will not be charged for this extra sheet.
* `certified_return_receipt` - request an electronic copy of the recipient's signature to prove delivery of your certified letter
* `registered` - provides tracking and confirmation for international addresses
Not available for `us_legal` letter size.
nullable: true
17 changes: 17 additions & 0 deletions resources/letters/attributes/ltr_size.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
type: string

enum:
- us_letter
- us_legal

description: >
Specifies the size of the letter. It accepts two values `us_letter` and `us_legal`.
If the [Lob-Version header](#tag/Versioning-and-Changelog) in the request is set to `2024-01-01` and above,
the `size` property is automatically included with the default value of `us_letter`,
unless explicitly specified.
Please note that attempting to include the `size` property in the request with the `Lob-Version` header
predating to `2024-01-01` will result in an error.
default: us_letter
1 change: 1 addition & 0 deletions resources/letters/letters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ post:
parameters:
- $ref: "../../shared/parameters/idempotency.yml#/idem-header"
- $ref: "../../shared/parameters/idempotency.yml#/idem-query"
- $ref: "../../shared/parameters/lob_version.yml#/lob-version"

requestBody:
required: true
Expand Down
7 changes: 5 additions & 2 deletions resources/letters/models/letter_editable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ allOf:
$ref: "../attributes/extra_service.yml"

cards:
description: A single-element array containing an existing card id in a string format. See [cards](#tag/Cards) for more information.
description: A single-element array containing an existing card id in a string format. See [cards](#tag/Cards) for more information. Not available for `us_legal` letter size.
type: array
items:
$ref: "../../../shared/attributes/model_ids/card_id.yml"
Expand Down Expand Up @@ -69,5 +69,8 @@ allOf:

fsc:
type: boolean
description: This is in beta. Contact [email protected] or your account contact to learn more. Not available for `A4` letter size.
description: This is in beta. Contact [email protected] or your account contact to learn more. Not available for `A4` and `us_legal` letter size.
default: false

size:
$ref: "../attributes/ltr_size.yml"
2 changes: 1 addition & 1 deletion shared/models/qr_code.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
type: object
description: Customize and place a QR code on the creative at the required position.
description: Customize and place a QR code on the creative at the required position. Not available for `us_legal` letter size.
required:
- position
- redirect_url
Expand Down
15 changes: 15 additions & 0 deletions shared/parameters/lob_version.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
lob-version:
in: header

name: Lob-Version

required: false

description: >
A string representing the version of the API being used. For more information on versioning,
refer to our [Versioning and Changelog]((#tag/Versioning-and-Changelog) documentation.
schema:
type: string
example: 2024-01-01
pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$"
Loading