Skip to content

Commit

Permalink
CMB-708: add pages property to booklet docs
Browse files Browse the repository at this point in the history
  • Loading branch information
sachinmurali committed Jul 12, 2024
1 parent b8dadf6 commit a8a4bb5
Show file tree
Hide file tree
Showing 11 changed files with 57 additions and 33 deletions.
49 changes: 27 additions & 22 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lob-api-public.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
openapi: 3.0.3

Check warning on line 1 in lob-api-public.yml

View workflow job for this annotation

GitHub Actions / Lint (push)

oas3-valid-media-example

This format violates OpenAPI 3.1 rules
info:
title: Lob
version: 1.19.36
version: 1.19.37
description: |
The Lob API is organized around REST. Our API is designed to have predictable, resource-oriented URLs and uses HTTP response codes to indicate any API errors. <p>
license:
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lob/openapi",
"version": "1.19.36",
"version": "1.19.37",
"engines": {
"node": ">=14.16.0",
"npm": ">=7.9.0"
Expand Down
6 changes: 6 additions & 0 deletions resources/booklets/attributes/booklet_pages.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
description: >-
Pages specifies the total number of pages in a booklet, where four pages make up one sheet.
Pages must always be in increments of four to maintain booklet integrity.
For a booklet with dimensions of 8.375x5.375 inches, we allow for 8, 12, 16, 20, 24, 28, or 32 pages.
type: integer
3 changes: 1 addition & 2 deletions resources/booklets/attributes/booklet_size.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
type: string

enum:
- 9x6
- 8.375x5.375

description: >
Specifies the size of the booklet.
default: 9x6
default: 8.375x5.375
6 changes: 3 additions & 3 deletions resources/booklets/booklets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ post:
right: "2"
pages: "1-2,4-5"
fsc: true
size: "9x6"
size: "8.375x5.375"

application/x-www-form-urlencoded:
schema:
Expand Down Expand Up @@ -136,7 +136,7 @@ post:
right: "2"
pages: "1-2,4-5"
fsc: true
size: "9x6"
size: "8.375x5.375"

multipart/form-data:
schema:
Expand Down Expand Up @@ -178,7 +178,7 @@ post:
right: "2"
pages: "1-2,4-5"
fsc: true
size: "9x6"
size: "8.375x5.375"

responses:
"200":
Expand Down
5 changes: 5 additions & 0 deletions resources/booklets/models/booklet_editable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ allOf:
- from
- file
- use_type
- pages
- size

properties:
file:
Expand All @@ -35,3 +37,6 @@ allOf:

size:
$ref: "../attributes/booklet_size.yml"

pages:
$ref: "../attributes/booklet_pages.yml"
6 changes: 6 additions & 0 deletions resources/booklets/models/booklet_generated_base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ allOf:
use_type:
$ref: "../attributes/booklet_use_type.yml"

size:
$ref: "../attributes/booklet_size.yml"

pages:
$ref: "../attributes/booklet_pages.yml"

fsc: # Forest Stewardship Council
type: boolean
description: This is in beta. Contact [email protected] or your account contact to learn more.
Expand Down
6 changes: 4 additions & 2 deletions resources/booklets/responses/all_booklets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ content:
large: https://lob-assets.com/order-creatives/ord_0d6a16a3fff6318ac8f8008dc1_comp_a20fd48ba4efda76ee827400d_thumb_large_1.png?version=v1&expires=1618512040&signature=kBrm00xkyCkJNJRHxH8HshFaebtOxnzjVWOs1VVmGMuw8H6OBNcMAMxt9s49K0jlpHoh3Nr9uSncEZMQaaNjAg
merge_variables:
name: Harry
size: 9x6
size: 8.375x5.375
pages: 8
expected_delivery_date: "2021-03-24"
date_created: "2021-03-16T18:40:40.504Z"
date_modified: "2021-03-16T18:40:40.504Z"
Expand Down Expand Up @@ -129,7 +130,8 @@ content:
large: https://lob-assets.com/order-creatives/ord_851100000f31bb1a872f794cee_comp_a20fd48ba4efda76ee827400d_thumb_large_1.png?version=v1&expires=1618512040&signature=kBrm00xkyCkJNJRHxH8HshFaebtOxnzjVWOs1VVmGMuw8H6OBNcMAMxt9s49K0jlpHoh3Nr9uSncEZMQaaNjAg
merge_variables:
name: Harry
size: 9x6
size: 8.375x5.375
pages: 8
expected_delivery_date: "2021-03-24"
date_created: "2021-03-16T18:40:40.504Z"
date_modified: "2021-03-16T18:40:40.504Z"
Expand Down
3 changes: 2 additions & 1 deletion resources/booklets/responses/booklet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ application/json:
large: https://lob-assets.com/order-creatives/ord_0d6a16a3fff6318ac8f8008dc1_comp_a20fd48ba4efda76ee827400d_thumb_large_1.png?version=v1&expires=1618512040&signature=kBrm00xkyCkJNJRHxH8HshFaebtOxnzjVWOs1VVmGMuw8H6OBNcMAMxt9s49K0jlpHoh3Nr9uSncEZMQaaNjAg
merge_variables:
name: Harry
size: 9x6
size: 8.375x5.375
pages: 8
expected_delivery_date: "2021-03-24"
date_created: "2021-03-16T18:40:40.504Z"
date_modified: "2021-03-16T18:40:40.504Z"
Expand Down

0 comments on commit a8a4bb5

Please sign in to comment.