Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add shebang to shim wrapper scripts #364

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

justice-adams-apple
Copy link
Contributor

After the update of the Cmake binary on our CI fleet, the way Cmake handles internal processes has changed and we need to explicitly set the shebang on our wrapper shims to avoid

    Error running link command: Unknown system error -8

Copy link

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For documentation purposes, CMake 3.28 (IIRC, though it got reverted a few times), switched from a custom solution for managing process execution to using libuv. This results in the script that is doing the execution being handled differently in cmake -E cmake_linker_script <wrapper_script>. Instead of being treated as a shell script, it's being treated as a raw executable binary. This doesn't work since it's a text file.

Adding the shebang or calling bash <script> in the wrapper script will fix it.
LGTM.

@etcwilde etcwilde merged commit 3fff39d into llvm:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants