[RISCV] Move rva23 evl builder over to cross-compile and execute under qemu-system setup #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r qemu-system setup This also moves to `prefer-predicate-over-epilogue=predicate-else-scalar-epilogue`. As the buildbot is on staging only and already has some failures, I think it's ok to make both changes at once rather than carefully staging it.
asb
force-pushed
the
2025q1-rva23-new-build-config
branch
from
8601a25 to
dedaca3
Compare
This was referenced Jan 22, 2025
lukel97
approved these changes
Jan 22, 2025
| "set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)"], | ||
| env={ | ||
| "BB_IMG_DIR": util.Interpolate("%(prop:builddir)s/.."), | ||
| "BB_QEMU_CPU": "zba=true,zbb=true,zbc=false,zbs=true,zfhmin=true,v=true,vext_spec=v1.0,zkt=true,zvfhmin=true,zvbb=true,zvkt=true,zihintntl=true,zicond=true,zcb=true,zfa=true,zawrs=true,rvv_ta_all_1s=true,rvv_ma_all_1s=true,rvv_vl_half_avl=true", |
There was a problem hiding this comment.
Do we also need to enable zimop +zcmop? Can clang emit those currently?
There was a problem hiding this comment.
I don't believe we will, but I'll enable them for completeness - thanks. They weren't supported at the time I composed that command line, but they were added in qemu 9.1.0.
Thanks!
There was a problem hiding this comment.
A patch is under review for rva23 support in QEMU, so I'll additionally add a TODO here to switch over to that shorthand once it's merged and in a released qemu version https://lore.kernel.org/qemu-devel/[email protected]/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves to
prefer-predicate-over-epilogue=predicate-else-scalar-epilogue. As the buildbot is on staging only and already has some failures, I think it's ok to make both changes at once rather than carefully staging it.