[clang-3.4-debuginfo-statistics] Fix the LNT submissions run order #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run order should be the GIT_DISTANCE of the stage 1 compiler which is being used to build the historic compiler.
| @@ -76,7 +89,7 @@ pipeline { | |||
| withCredentials([string(credentialsId: 's3_resource_bucket', variable: 'S3_BUCKET')]) { | |||
| sh """ | |||
| source ./venv/bin/activate | |||
| echo "ARTIFACT=${params.ARTIFACT}" | |||
| export $(grep ARTIFACT last_good_build.properties) | |||
There was a problem hiding this comment.
I this still downloading the toolchain package?
There was a problem hiding this comment.
Yes, it should. It points the ARTIFACT to the one listed in last_good_build.properties and that is fetched in the next line.
justice-adams-apple
approved these changes
Oct 31, 2024
|
Thanks for addressing this! Makes sense to me. I found this bit of the pipeline suspicious when I was looking into doing the same for the lldb-statistics bot. I'll defer to @justice-adams-apple for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run order should be the GIT_DISTANCE of the stage 1 compiler which is being used to build the historic compiler.