Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Scala native 0.4 to 0.5 (fixes #401) #402

Closed

Conversation

MateuszKubuszok
Copy link
Contributor

@MateuszKubuszok MateuszKubuszok commented Aug 15, 2024

I edited only these dependencies that had to be updated for Scala Native 0.5.

enumeratumPlayNative and enumeratumPlayJson does not compile (because one would have to enumeratumCore/publishLocal), but it should be close enough.

@MateuszKubuszok MateuszKubuszok changed the title Migrate from Scala native 0.4 to 0.5 Migrate from Scala native 0.4 to 0.5 (#401) Aug 15, 2024
@MateuszKubuszok MateuszKubuszok changed the title Migrate from Scala native 0.4 to 0.5 (#401) Migrate from Scala native 0.4 to 0.5 (fixes #401) Aug 15, 2024
@MateuszKubuszok MateuszKubuszok mentioned this pull request Aug 15, 2024
@kubukoz
Copy link
Contributor

kubukoz commented Sep 10, 2024

@MateuszKubuszok you need to update the scalajs version:

diff --git a/project/plugins.sbt b/project/plugins.sbt
index a481eab..c9268fe 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -7,7 +7,7 @@ addSbtPlugin("com.github.tkawachi" % "sbt-doctest"   % "0.10.0")
 addSbtPlugin("com.github.sbt"      % "sbt-pgp"       % "2.2.1")
 addSbtPlugin("com.eed3si9n"        % "sbt-buildinfo" % "0.11.0")
 
-addSbtPlugin("org.scala-js"       % "sbt-scalajs"              % "1.13.2")
+addSbtPlugin("org.scala-js"       % "sbt-scalajs"              % "1.16.0")
 addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.3.2")
 
 addSbtPlugin("org.scala-native"   % "sbt-scala-native"              % "0.5.4")

the dependency bumps (e.g. cats) must've brought in a more recent scalajs version, so you need to compile/link against one that's able to understand its IR

@kubukoz
Copy link
Contributor

kubukoz commented Sep 11, 2024

Superseded by #403, thanks for laying the groundwork (or should I say, doing 99% of the work) @MateuszKubuszok :)

@MateuszKubuszok MateuszKubuszok deleted the scala-native0.5 branch September 12, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants