stream-mngr: wrap comfyui json into prompt field #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mjh1
reviewed
Dec 23, 2024
| updatedStream.from_playground = false;//set flag indicating this is not ephemeral stream being shown in the Try/Playground components/views | ||
| updatedStream.from_playground = false; // set flag indicating this is not ephemeral stream being shown in the Try/Playground components/views | ||
|
|
||
| if (updatedStream.pipeline_params && updatedStream.pipelines?.type === "comfyui") { |
There was a problem hiding this comment.
Maybe also just check there isn't a "prompt" field already. But yep this lgtm when testing
Ah oops I realised this means that the prompt shows in the editor, and then you'll get a new "prompt" wrapper each time
|
This PR should be closed and not merged as this issue was addressed by the new comfyui param editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promptwhen creating or updating streams