Allow passing all SIP trunk options in CreateSIPParticipant. #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a81fde8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
davidzhao
reviewed
Feb 3, 2025
protobufs/livekit_sip.proto
Outdated
| @@ -521,6 +521,7 @@ message DeleteSIPDispatchRuleRequest { | |||
| message CreateSIPParticipantRequest { | |||
| // What SIP Trunk should be used to dial the user | |||
| string sip_trunk_id = 1; | |||
| SIPOutboundTrunkInfo sip_trunk = 20; | |||
There was a problem hiding this comment.
IMO it seems rather confusing to embed all of the options from a SIP Trunk here. I would vote for just including the fields that are needed explicitly
- url
- username
- password
dennwc
force-pushed
the
sip-outbound-no-trunk
branch
from
e8d19b4 to
a029285
Compare
|
@davidzhao Done, added the remaining trunk fields in a separate config proto. Or do you prefer unwrapping it into a top-level message? Also note that it doesn't accept a raw SIP URI, instead it specifies hostname and transport separately. |
davidzhao
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.