Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SIP statuses as RPC error details. #958

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Pass SIP statuses as RPC error details. #958

merged 1 commit into from
Jan 29, 2025

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Jan 29, 2025

Revert passing SIP status codes in success response (part of #952). They will be passed as gRPC/PSRPC error details. Add helpers to make it work with Twirp as well.

@dennwc dennwc requested a review from a team January 29, 2025 14:50
@dennwc dennwc self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 2493570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc merged commit c909c95 into main Jan 29, 2025
3 checks passed
@dennwc dennwc deleted the sip-status-err branch January 29, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants