Skip to content

Commit

Permalink
Add flag to make CreateSIPParticipant synchronous.
Browse files Browse the repository at this point in the history
  • Loading branch information
dennwc committed Jan 27, 2025
1 parent 6ec1903 commit 175b821
Show file tree
Hide file tree
Showing 9 changed files with 358 additions and 287 deletions.
6 changes: 6 additions & 0 deletions .changeset/perfect-forks-draw.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@livekit/protocol": minor
"github.com/livekit/protocol": minor
---

Add flag to make CreateSIPParticipant synchronous.
22 changes: 17 additions & 5 deletions livekit/livekit_sip.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

350 changes: 176 additions & 174 deletions livekit/livekit_sip.twirp.go

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion protobufs/livekit_sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,10 @@ message CreateSIPParticipantRequest {
bool krisp_enabled = 14;

SIPMediaEncryption media_encryption = 18;
// NEXT ID: 19

// Wait for the answer for the call before returning.
bool wait_until_answered = 19;
// NEXT ID: 20
}

message SIPParticipantInfo {
Expand Down
8 changes: 7 additions & 1 deletion protobufs/rpc/sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,19 @@ message InternalCreateSIPParticipantRequest {

livekit.SIPMediaEncryption media_encryption = 28;

// NEXT ID: 29
// Wait for the answer for the call before returning.
bool wait_until_answered = 29;

// NEXT ID: 30
}

message InternalCreateSIPParticipantResponse {
string participant_id = 1;
string participant_identity = 2;
string sip_call_id = 3;

uint32 sip_failure_code = 4;
string sip_failure_reason = 5;
}

message InternalTransferSIPParticipantRequest {
Expand Down
1 change: 1 addition & 0 deletions rpc/sip.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ func NewCreateSIPParticipantRequest(
RingingTimeout: req.RingingTimeout,
MaxCallDuration: req.MaxCallDuration,
MediaEncryption: enc,
WaitUntilAnswered: req.WaitUntilAnswered,
}, nil
}

Expand Down
119 changes: 76 additions & 43 deletions rpc/sip.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 175b821

Please sign in to comment.